Re: [PATCH 07/12] HID: hid-lg4ff: Protect concurrent access to the output HID report values with a spinlock.

[Jiri Kosina]

On Sat, 21 Mar 2015, Michal Malà wrote:

> Since all functions that need to send some data to the device they
> manage share the same HID report some synchronization is needed to
> prevent sending bogus data to the device.

This patch is doing much more than just adding a mutual exclusion 
mechanisms (for example the wdata indirection), so more descriptive 
changelog is needed.

Looking at the patch it's actually not clear at all what are all the 
things it's trying to do, so please resend v2 of this patch with much more 
verbose changelog, so that I am able to review it properly. Thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/