Re: linux-next: build warning after merge of the char-misc tree

[Fabian Frederick]

> On 27 March 2015 at 08:48 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
>
> Hi all,
>
> After merging the char-misc tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> In file included from include/linux/module.h:17:0,
>Â Â Â Â Â Â Â Â Â from drivers/uio/uio_pdrv_genirq.c:21:
> include/linux/moduleparam.h:326:22: warning: initialization discards 'const'
> qualifier from pointer target type
> Âstatic const struct kparam_string __param_string_##name \
>Â Â Â Â Â Â Â Â Â Â Â Â^
> drivers/uio/uio_pdrv_genirq.c:260:1: note: in expansion of macro
> 'module_param_string'
>Â module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
>Â ^
>
> Introduced by commit 4d8beff2ae07 ("uio: constify of_device_id array").

Hi Stephen,

Absolutely, my patch is wrong ; comment below explains struct is filled
afterwards.Sorry.
Greg, should I send you a revert or maybe we could standardize that driver ? (it
seems it's the only one to work that way).

static const struct of_device_id uio_of_genirq_match[] = {
    { /* This is filled with module_parm */ },
    { /* Sentinel */ },
};

Regards,
Fabian

> --
> Cheers,
> Stephen Rothwell          sfr@xxxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/