Re: [PATCH 3/9] perf sched replay: Alloc the memory of pid_to_task dynamically to adapt to the unexpected change of pid_max

[Arnaldo Carvalho de Melo]

Em Tue, Mar 31, 2015 at 04:26:04PM -0600, David Ahern escreveu:
> On 3/31/15 2:25 PM, Arnaldo Carvalho de Melo wrote:
> >Humm, we already have an rb_tree for each task, its called
> >machine->threads, and it has struct thread instances, that in turn have
> >a ->priv point, can't it be used here?

> I think that would require a lot of churn to the existing code. The command
> could definitely use some modernizing, but it will take time.

yeah, I've been there, some of the infrastructure changes here and there
are related to this, i.e. how to make the core more useful for tools
like 'sched' :-)

I.e. at some point it should be just a struct thread descendant, i.e.
something like:

struct sched_thread {
	struc thread thread;
	sched specific fields;
};

or have the sched specific fields accessible via thread->priv.

The former may be better performance wise due to data locality, i.e.
better cacheline usage. This is something I did, for instance, for
perf_evsel/hists_evsel.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/