Re: Re: msgrcv: use freezable blocking call
From: Peter Zijlstra
Date: Wed Apr 01 2015 - 03:36:01 EST
On Wed, Apr 01, 2015 at 05:18:46AM +0000, Maninder Singh wrote:
> Hi Andrew,
> Thanks for making new patch, Actually there is some problem with our mail editor.
> It changes tabs with spaces and corrupts the patch, we are solving the same at our end.
> Thats why i am sending you signed -off by only for both patches.
Sort it and resend, no real great hurry with these patches, right?
> 1. For msgrcv: use freezable blocking call
> Signed-off-by: Yogesh Gaur <yn.gaur@xxxxxxxxxxx>
> Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
> Signed-off-by: Manjeet Pawar <manjeet.p@xxxxxxxxxxx>
Did you really pass around that patch through 3 people or did it take
all three of you to modify those two lines?
Should some of those SoBs be a reviewed-by perhaps?
> ----> For Peter's Review comment:- This is what, no why mentioned
> This call was selected to be converted to a freezable call because
> it doesn't hold any locks or release any resources when interrupted
> that might be needed by another freezing task or a kernel driver
> during suspend, and is a common site where idle userspace tasks are
Please put such things in the Changelog so that we can see you've
thought about things.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/