Re: [PATCH 3/5] ARM: mvebu: Allow using the GIC for wakeup in standby mode

[Gregory CLEMENT]

Hi Marcin,

On 01/04/2015 10:34, Marcin Wojtas wrote:
> Hi Gregory,
> 
> 2015-03-30 16:04 GMT+02:00 Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>:
>> On the Armada 375/38x/39x SoCs, in standby mode the SoC stay powered
>> and it is possible to wake-up from any interrupt sources. This patch
>> adds flag to the GIC irqchip driver to let linux know this.
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm/mach-mvebu/board-v7.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c
>> index 89a139ed7d5b..61774279a66d 100644
>> --- a/arch/arm/mach-mvebu/board-v7.c
>> +++ b/arch/arm/mach-mvebu/board-v7.c
>> @@ -18,6 +18,7 @@
>>  #include <linux/of_address.h>
>>  #include <linux/of_fdt.h>
>>  #include <linux/of_platform.h>
>> +#include <linux/irq.h>
>>  #include <linux/io.h>
>>  #include <linux/clocksource.h>
>>  #include <linux/dma-mapping.h>
>> @@ -26,6 +27,7 @@
>>  #include <linux/signal.h>
>>  #include <linux/slab.h>
>>  #include <linux/irqchip.h>
>> +#include <linux/irqchip/arm-gic.h>
>>  #include <asm/hardware/cache-l2x0.h>
>>  #include <asm/mach/arch.h>
>>  #include <asm/mach/map.h>
>> @@ -129,6 +131,11 @@ static int armada_375_external_abort_wa(unsigned long addr, unsigned int fsr,
>>
>>  static void __init mvebu_init_irq(void)
>>  {
>> +       if (of_machine_is_compatible("marvell,armada375") ||
>> +           of_machine_is_compatible("marvell,armada380") ||
>> +           of_machine_is_compatible("marvell,armada390"))
>> +               gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE |
>> +                                     IRQCHIP_MASK_ON_SUSPEND);
> 
> I'm afraid you the patchset may be incomplete:
> arch/arm/mach-mvebu/board-v7.c:137:3: error: implicit declaration of
> function 'gic_set_irqchip_flags'
> [-Werror=implicit-function-declaration]

Actually I forgot to speak about the dependency.

This patch depends on the commit "irqchip: gic: Add an entry point to set up irqchip flags"
which is already in the irqchip branch and will be part of 4.1.

So in case it would be ok to merge it in 4.1 (but I doubt it it will be the case), then
this patch should be taken by the irqchip subsystem to resolve this dependency. I checked
that it should not conflict with the mvebu patches.

Thanks,

Gregory


> 
> Best regards,
> Marcin
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/