Re: Re: [Fix kernel crash in cipso_v4_sock_delattr ]

[Maninder Singh]

We have run trinity tool on smack enable system. like below:-

#./trinity -c sendto --dangerous
After some time we are able to crash the kernel:-

[<c04c8084>] (cipso_v4_sock_delattr+0x0/0x74) from [<c0517c44>] (netlbl_sock_delattr+0x18/0x1c)
 r4:00000000 r3:c07872f8
[<c0517c2c>] (netlbl_sock_delattr+0x0/0x1c) from [<c027b3e0>] (smack_netlabel+0x88/0x9c)
[<c027b358>] (smack_netlabel+0x0/0x9c) from [<c027b520>] (smack_netlabel_send+0x12c/0x144)
 r7:d9cee3c0 r6:d7b01ef4 r5:c076f408 r4:d88c84c0
[<c027b3f4>] (smack_netlabel_send+0x0/0x144) from [<c027b58c>] (smack_socket_sendmsg+0x54/0x60)
[<c027b538>] (smack_socket_sendmsg+0x0/0x60) from [<c0278ad0>] (security_socket_sendmsg+0x28/0x2c)
[<c0278aa8>] (security_socket_sendmsg+0x0/0x2c) from [<c0434490>] (sock_sendmsg+0x68/0xc0)
[<c0434428>] (sock_sendmsg+0x0/0xc0) from [<c0436ac8>] (SyS_sendto+0xd8/0x110)
 r7:01400118 r6:0000007f r5:da308a00 r4:c076f408
[<c04369f0>] (SyS_sendto+0x0/0x110) from [<c0012280>] (ret_fast_syscall+0x0/0x48)
Code: e5903200 e1a04000 e3530000 089da818 (e5d33016)
[SELP] while loop ... please attach T32...

And after further debugging we find this crash always come with Netlink socket.
And except thi API "netlbl_sock_delattr"  all other related Netlabel APIs have check to validate socket family.
Thats why we added socket family check for this API "netlbl_sock_delattr" and resolves our issue.

Thanks 
Maninder Singh

On 3/30/2015 10:09 PM, Maninder Singh wrote:
> We are currently using 3.10.58 kernel and  we are facing this issue for samck enabled system.
> and as we can check in other APIs like netlbl_sock_getattr and netlbl_conn_setattr have this preventive check so we added this check for netlbl_sock_delattr also.
>
> And regarding patch re-submission, actually we have run checkpatch.pl before submission(successfull)  But when we submit the patch our editor changes tabs into space, we will resubmitt the patch ASAP.

Further review shows that the Smack code in 3.10.72 (I don't believe it changed
after 3.10.58) already checks for the address family being AF_INET. This would indicate
that the netlink code is sending garbage to security_socket_sendmsg().

Can you provide a more specific test case? I would like to see if this problem is
present in newer kernels.

>
> Maninder Singh
> ------- Original Message -------
> Sender : Casey Schaufler
> Date : Mar 31, 2015 02:25 (GMT+09:00)
> Title : Re: [Fix kernel crash in cipso_v4_sock_delattr ]
>
> On 3/30/2015 4:32 AM, Paul Moore wrote:
>> On Monday, March 30, 2015 11:09:00 AM Maninder Singh wrote:
>>> Dear All,
>>> we found One Kernel Crash issue in cipso_v4_sock_delattr :-
>>> As Cipso supports only inet sockets so cipso_v4_sock_delattr will crash when
>>> try to access any other socket type.  cipso_v4_sock_delattr access
>>> sk_inet->inet_opt which may contain not NULL but invalid address. we found
>>> this issue with netlink socket.(reproducible by trinity using sendto system
>>> call .) 
>> Hello,
>>
>> First, please go read the Documentation/SubmittingPatches from the kernel 
>> sources; your patch needs to be resubmitted and the instructions in that file 
>> will show you how to do it correctly next time.
>>
>> Second, this appears to only affect Smack based systems, yes?  SELinux based 
>> systems should have the proper checking in place to prevent this (the checks 
>> are handled in the LSM).
> This looks like a problem that was fixed some time ago.
> The current Smack code clearly checks for this. What kernel
> version are you testing against?
>
>> That said, it probably wouldn't hurt to add the 
>> extra checking to netlbl_sock_delattr().  If you properly resubmit your patch 
>> I'll ACK it.
>>
>> -Paul