Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

From: Jason Gunthorpe
Date: Wed Apr 01 2015 - 14:19:45 EST

On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote:
> Added PPI interface to the character device. PPI interface is also kept
> in the pdev for backwards compatibility.

Could you look at just completely moving the PPI interface to the char
dev and then adding a symlink from the pdev? That would be really

symlinks have the advantage that they actually fully fix the lifetime

This seems doable, if we replace the ppi_attrs group with a bunch of
calls to sysfs_create_link it should work ?

> +static struct tpm_chip *ppi_dev_to_chip(struct device *dev)
> +{
> + struct tpm_chip *chip = dev_get_drvdata(dev);
> +
> + if (chip == NULL)
> + chip = to_tpm_chip(chip);
> +
> + return chip;
> +}

If symlinks don't work out, we should probably just set the drvdata on
the tpm_chip itself to avoid this.

> + if (!(chip->flags & TPM_CHIP_FLAG_PPI))
> + return -EINVAL;

Hum, I don't think the PPI files should be created if there is no PPI

> +void __init tpm_ppi_init(struct class *tpm_class)
> +{
> + tpm_class->dev_groups = tpm_groups;
> }

So this shouldn't be unconditional.

Also, ultimately PPI can't just claim the dev_groups, other parts of
the driver will need to add groups too.

I think it makes more sense to do

struct attribute_group *tpm_ppi_get_sysfs(struct tpm_chip *chip)

And take care of building the list in the caller.

And tpm_ppi_get_sysfs should be called after the driver is readied but
before adding the device.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at