Re: [PATCH v3] x86, earlyprintk: Fix two 'defined but not used' compile warnings

From: Borislav Petkov
Date: Thu Apr 02 2015 - 00:37:45 EST

On Wed, Apr 01, 2015 at 10:32:04PM +0100, Mark Einon wrote:
> Two static functions are only used if CONFIG_PCI is defined,so only build them
> if this is the case. Fixes the build warnings:
> arch/x86/kernel/early_printk.c:98:13: warning: âmem32_serial_outâ defined but not used [-Wunused-function]
> static void mem32_serial_out(unsigned long addr, int offset, int value)
> ^
> arch/x86/kernel/early_printk.c:105:21: warning: âmem32_serial_inâ defined but not used [-Wunused-function]
> static unsigned int mem32_serial_in(unsigned long addr, int offset)
> ^
> Also convert a few related instances of uintXX_t to kernel specific uXX defines.
> Signed-off-by: Mark Einon <mark.einon@xxxxxxxxx>
> ---
> v2 - Move code to another #ifdef instead of creating a new ifdef pair after
> comment by Borislav Petkov <bp@xxxxxxxxx>.
> v3 - Fixed commit errors from v2, changed some uintXX_t data types to equivalent uXX.
> arch/x86/kernel/early_printk.c | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)

Applied, thanks.


ECO tip #101: Trim your mails when you reply.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at