Re: [PATCH] mtd: Add simple read disturb test

From: Fabio Estevam
Date: Thu Apr 02 2015 - 10:45:09 EST

On Thu, Apr 2, 2015 at 11:33 AM, Richard Weinberger <richard@xxxxxx> wrote:

> Why? Free()ing a NULL pointer is perfectly fine.
> What did I miss? :)

If the first 'iobuf = kmalloc(mtd->erasesize, GFP_KERNEL);' fails then
you jump to the out label where you call 5 kfree() and then return the

It would be much better just to return the error immediately in this
case and add one label for each allocation error, so that it only
kfree the previous successful allocations.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at