Re: [PATCH perf/core v2] perf-probe: Fix to track down unnamed union/structure members
From: Arnaldo Carvalho de Melo
Date: Thu Apr 02 2015 - 10:57:41 EST
Em Thu, Apr 02, 2015 at 04:33:12PM +0900, Masami Hiramatsu escreveu:
> Fix perf probe to track down unnamed union/structure members.
> perf probe did not track down the tree of unnamed union/structure
> members, since it just failed to find given "name" in a parent
> structure/union. To solve this issue, I've introduced 2 changes.
> - Fix die_find_member() to track down the type-DIE if it is
> unnamed, and if it contains the specified member, returns the
> unnamed member.
> (note that we don't return found member, since unnamed member
> has the offset in the parent structure)
> - Fix convert_variable_fields() to track down the unnamed union/
> structure (one-by-one).
> With this patch, perf probe can access unnamed fields.
> #./perf probe -nfx ./perf lock__delete ops 'locked_ops=ops->locked.ops'
> Added new event:
> probe_perf:lock__delete (on lock__delete in /home/mhiramat/ksrc/linux-3/tools/perf/perf with ops locked_ops=ops->locked.ops)
> You can now use it in all perf tools, such as:
> perf record -e probe_perf:lock__delete -aR sleep 1
> The original report of this issue is: https://lkml.org/lkml/2015/3/5/431
Thanks a lot! Applied, built and tested, all works as expected,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/