Re: [PATCH v2.1] ftracetest: Do not use usleep directly

[Steven Rostedt]

On Thu, 02 Apr 2015 08:20:09 -0600
Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:


> >>> Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> >>> Reported-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
> >>> Reported-by: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>
> >>> Based-on-patch-by: PÃdraig Brady <P@xxxxxxxxxxxxxx>
> 
> Is this standard? checkpatch complained as non-standard. I am
> seeing some patches posted with Based-on-patch-by

I ignore checkpatch for things like this. It doesn't have a foggiest
clue to what is standard. The only standard we truly have that counts
is "Signed-off-by", as that's partially a legal thing. Everything else
is info only.

This patch was based on a idea by PÃdraig Brady and Namhyung is giving
him credit.

Hmm, since I do not believe that PÃdraig sent a patch, but only
suggested the idea, the more "standard" tag, and actually more
appropriate tag would be:

Suggested-by: PÃdraig Brady <P@xxxxxxxxxxxxxx>

Also, we probably should add:

Link: http://lkml.kernel.org/r/1427329943-16896-1-git-send-email-namhyung@xxxxxxxxxx

Which has more of a history for this patch.

> 
> Anyway, I have this patch tagged for 4.1-rc2

Why rc2?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/