Re: [PATCH 21/21] time: Rework debugging variables so they aren't global
From: Ingo Molnar
Date: Fri Apr 03 2015 - 02:21:16 EST
* John Stultz <john.stultz@xxxxxxxxxx> wrote:
> On Thu, Apr 2, 2015 at 12:51 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> > * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >> On Wed, Apr 01, 2015 at 08:34:41PM -0700, John Stultz wrote:
> >> > Ingo suggested that the timekeeping debugging variables
> >> > recently added should not be global, and should be tied
> >> > to the timekeeper's read_base.
> >> But why? its the same hardware clock for both tkr's. Surely if one goes
> >> funny the other will too.
> >> It doesn't make sense to duplicate this.
> > Well, could it be moved to the timekeeper data structure? What I was
> > opposed to was making it super-global, after all the (nice) effort we
> > made to tidy up global data structures in this area.
> Ok. I'll rework this then and resend. Though if there's no objections
> to Xunlei's portion of the series, would you mind merging those into
> -tip? I'd like to make sure they get some time in -next before the
> merge window opens.
Yeah, it all looks good to me, I've picked up all but this one patch
from your series and will push it out once it has gone through
I updated some of the titles and changelogs and added a few more Cc:s
where it seemed appropriate.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/