Re: [PATCHv3] media: i2c/adp1653: devicetree support for adp1653

From: Pavel Machek
Date: Fri Apr 03 2015 - 04:23:54 EST


> Hi Pawel,

I'm still Pavel. v, not w.

> > > Hi Pawel,

> > > A corresponding change to the N900 dts would be very nice.
> >
> > Corresponding change to the dts will come in separate patch. Or do you
> > have n900 for testing?
> Yes, it should be a separate patch, I agree.
> I do have one but I can't say when I'd have time to test it. I'm fine with
> you having tested it though.
> > > I think you're missing change to adp1653_i2c_driver.driver.of_match_table.
> >
> > It actually worked for me, which means device tree somehow does it
> > magic.
> By magic? :-) It probably just ends up comparing the device and the driver
> names. How about adding the of_match_table?

I guess it uses adp1653_id_table. I'd hade to add redundand
information, because if it would just mask the errors if the code


(cesky, pictures)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at