Re: [PATCH] mvneta: implement SGMII-based in-band link state signaling

From: Stas Sergeev
Date: Fri Apr 03 2015 - 06:00:45 EST

03.04.2015 03:51, David Miller ÐÐÑÐÑ:
> From: Stas Sergeev <stsp@xxxxxxx>
> Date: Tue, 31 Mar 2015 16:24:59 +0300
>> @@ -2590,6 +2651,7 @@ static int mvneta_mdio_probe(struct mvneta_port *pp)
>> static void mvneta_mdio_remove(struct mvneta_port *pp)
>> {
>> + fixed_phy_set_link_update(pp->phy_dev, NULL);
> I do not see any other driver doing this on shutdown.
> Please show me why it is necessary.
Hello David, sorry for this being discussed in a different thread,
so here you have a few pointers to why is this needed:

> And if it is, all other drivers registering a fixed phy link update
> function need to be adjusted to do the same thing.
Or, for example, get rid of the callback and add an API:

Then you get the patch that avoids all this call-back singing and dancing:

In any case, I posted 3 different implementations and hope
people will choose the best one (any choice is fine with me).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at