Re: [PATCH] x86/xsave: Robustify and merge macros

From: Quentin Casasnovas
Date: Fri Apr 03 2015 - 11:39:19 EST

On Fri, Apr 03, 2015 at 05:23:24PM +0200, Borislav Petkov wrote:
> On Fri, Apr 03, 2015 at 04:14:26PM +0200, Quentin Casasnovas wrote:
> > > This is obviously completely un-tested and not even compiled! :)
> > >
> >
> > Told you!
> :-)
> So all clear or we need to do more discussing?
> Basically, the .skip is supposed to add 0x90 only when the evaluated
> expression is true (yeah, gas works with signed 32-bit values so it
> evaluates either to 0 or -1, thus the games with "-" in front).

Oh yeah that was clear from the beggings, there was just a typo in my
initial suggestion to fix what I _think_ the problem is (which I've fixed
inlined so you might have missed it).

So yeah I still think we're not properly padding, if you take my earlier
example where repl2 = 5 bytes, repl1 = 4 bytes and orin_insn = 3.

I'll let you re-read my original mail and come back to me to tell me what'd
I really miss! :)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at