Re: [PATCH] drivers/i2c/i2c-core.c: Fix sparse warning

From: Wolfram Sang
Date: Fri Apr 03 2015 - 14:27:52 EST



> - u8 addr = (msg->addr << 1) | !!(msg->flags & I2C_M_RD);
> + u8 addr = (msg->addr << 1) | ((msg->flags & I2C_M_RD) != 0);

I prefer !! as an idiom for "bit to bool".

Thanks,

Wolfram

Attachment: signature.asc
Description: Digital signature