Re: [PATCH 2/2] soc: qcom: Add Shared Memory Manager driver

[Paul Bolle]

On Fri, 2015-04-03 at 16:03 -0700, Bjorn Andersson wrote:
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
 
> +config QCOM_SMEM
> +	tristate "Qualcomm Shared Memory Manager (SMEM)"
> +	depends on ARCH_QCOM
> +	help
> +	  Say y here to enable support for the Qualcomm Shared Memory Manager.
> +	  The driver provides an interface to items in a heap shared among all
> +	  processors in a Qualcomm platform.

> --- a/drivers/soc/qcom/Makefile
> +++ b/drivers/soc/qcom/Makefile
> @@ -1 +1,2 @@

> +obj-$(CONFIG_QCOM_SMEM) +=	smem.o

Just to make absolutely sure I'm not misreading this Makefile: if
QCOM_SMEM is set to 'm' this will generate the module smem.ko, right?

> --- /dev/null
> +++ b/drivers/soc/qcom/smem.c
> @@ -0,0 +1,763 @@
> +/*
> + * Copyright (c) 2015, Sony Mobile Communications AB.
> + * Copyright (c) 2012-2013, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

> +MODULE_LICENSE("GPLv2");

"GPLv2" doesn't indicate a GPL compatible license according to
include/linux/license.h. Loading smem.ko should trigger a warning and
taint the kernel. So you want
    MODULE_LICENSE("GPL v2");

here. 


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/