Re: [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup()

[Jonathan Corbet]

On Sat,  4 Apr 2015 03:16:01 +0300
Alexey Khoroshilov <khoroshilov@xxxxxxxxx> wrote:

> If i2c_add_adapter() fails, adap is not deallocated.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

Actually, the worse thing is that it leaves the IRQ enabled...it's good
you moved that lines down.  Even better, of course, that the failure path
has probably never been run during the life of this driver...:)

Should there be some sort of proper reported-by line for the driver
verification project?

Acked-by: Jonathan Corbet <corbet@xxxxxxx>

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/