Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

From: Joe Perches
Date: Sat Apr 04 2015 - 11:52:51 EST

On Sat, 2015-04-04 at 16:58 +0300, Dan Carpenter wrote:
> On Sat, Apr 04, 2015 at 12:04:59AM +0300, Dan Carpenter wrote:
> > 1) It's more clear when read in English. "if not strcmp then" or
> > "if strcmp NOT EQUAL zero".
> Oops. I got that reversed. I meant "if strcmp then". Only serves to
> emphasize my point though. :)

When I read it I understood what you meant, but
I thought the point was everybody makes mistakes.

!strcmp to test equality is still pretty idiomatic.
!memcmp too.

cheers, Joe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at