Re: [rtc-linux] [PATCH] rtc: hym8563: fix swapped enable/disable of clockout control bit

From: Alexandre Belloni
Date: Sun Apr 05 2015 - 05:06:15 EST

On 05/04/2015 at 02:20:24 +0200, Heiko Stübner wrote :
> The hym8563 datasheet describes the clock output control-bit as "when set
> to logic 0, the square wave output is enable, when set to logic 1, the
> CLKOUT output is inhibited". But in reality the setting is exactly
> opposite.
> Before now, the clock output was not really used, but on the rk3288 soc
> this generated clock is used to supply the temperature sensor block and
> the swapped bit value prevented it from working. With the corrected value,
> the tsadc now reports correct values.
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>

Should that patch be applied on any stable version too?

Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at