Re: [PATCH v2] crypto: remove instance when test failed

[Herbert Xu]

On Fri, Apr 03, 2015 at 09:29:44PM +0200, Stephan Mueller wrote:
>
> What about moving the current crypto_unregister_instance into 
> __crypto_unregister_instance and creating a new crypto_unregister_instance 
> that takes the ref count and once it got it, it calls 
> __crypto_unregister_instance. If it did not get the ref count, it simply 
> returns because the inst apparently was already removed.
> 
> Only the crypto_unregister_instance is EXPORT_SYMBOL whereas the 
> __crypto_unregister_instance is static.

That's not going to work because you need to grab the reference
count before you release the mutex.  Let me fix up crypto_user first
and then you can use it for your case too (or at least borrow the
idea).

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/