Re: [PATCH v2 0/5] Refactor Qualcomm RPM regulator to single platform_device

From: Bjorn Andersson
Date: Mon Apr 06 2015 - 12:40:39 EST

On Thu, Apr 2, 2015 at 3:57 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> On 04/02/15 15:26, Mark Brown wrote:
>> On Thu, Apr 02, 2015 at 03:00:37PM -0700, Stephen Boyd wrote:
>>> What happens with debugfs when you have multiple pmics with the same
>>> named regulator? I thought that in this case we needed to make the names
>>> unique somehow or we would end up with the same directory for two
>>> different regulators.
>> Guenther sent a patch fixing that a while back.
> This one?
> commit a9eaa8130707d4013fb109b80323489c0d0111ac
> Author: Guenter Roeck <linux@xxxxxxxxxxxx>
> AuthorDate: Fri Oct 17 08:17:03 2014 -0700
> Commit: Mark Brown <broonie@xxxxxxxxxx>
> CommitDate: Fri Mar 27 16:14:18 2015 -0700
> regulator: Ensure unique regulator debugfs directory names
> Ok. Seems to be only in next. I'm not sure it will work though because
> in this case the parent device is the same for both regulators on
> different PMICs that the RPM is controlling. I could be wrong though
> because I haven't tested it.

You're right Stephen; for the platforms with multiple pmics this will
spit out a bunch of warnings and Guenter's fix does not change that

Either we make the regulator names more specific (like pm8058_l1) or
we build out of pdev->dev.of_node->name and the regulator
name. I like the latter, so unless someone object I'll respin it that

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at