Re: [PATCH] mvneta: dont call mvneta_adjust_link() manually

[David Miller]

From: Stas Sergeev <stsp@xxxxxxx>
Date: Wed, 01 Apr 2015 19:23:29 +0300

> 
> mvneta_adjust_link() is a callback for of_phy_connect() and should
> not be called directly. The result of calling it directly is as below:
> ---
>  mvneta f1030000.ethernet eth1: Link is Up - Unsupported (update p
> hy.c)/Half - flow control off
> ---
> 
> This is because initially the struct phy_device is created with
> invalid parameters. phylib calls adjust_link() only when the parameters
> are validated, but calling it by hands may happen too early.
> 
> CC: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
> CC: netdev@xxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> CC: Florian Fainelli <f.fainelli@xxxxxxxxx>
> 
> Signed-off-by: Stas Sergeev <stsp@xxxxxxxxxxxxxxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/