Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations
From: Vineet Gupta
Date: Tue Apr 07 2015 - 08:47:14 EST
On Sunday 05 April 2015 11:55 PM, Joe Perches wrote:
These structs can be const, so make them const.
o Add static to struct uart_ops declaration in bfin_sport_uart
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx><mailto:joe@xxxxxxxxxxx>
On Sun, 2015-04-05 at 00:04 +0200, Stefan Agner wrote:
> On 2015-04-04 19:47, Joe Perches wrote:
> > Done with:
> > sed -r -i -e 's/\bstruct\s+uart_ops\s+(\w+)\s*=\s*/const struct
> > uart_ops \1 = /g' drivers/tty/serial/*.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> Something went wrong in this driver, const is twice...
Apologies, thanks for noticing.
The sed was mistakenly done twice on that file.
o Fix duplicate const in fsl_lpuart.c
o Add static to drivers/tty/serial/bfin_sport_uart.c
Still compiled only x86 and not cross-compiled or tested.
drivers/tty/serial/21285.c | 2 +-
drivers/tty/serial/altera_jtaguart.c | 2 +-
drivers/tty/serial/altera_uart.c | 2 +-
drivers/tty/serial/amba-pl010.c | 2 +-
drivers/tty/serial/amba-pl011.c | 2 +-
drivers/tty/serial/apbuart.c | 2 +-
drivers/tty/serial/ar933x_uart.c | 2 +-
drivers/tty/serial/arc_uart.c | 2 +-
Acked-by: Vineet Gupta <vgupta@xxxxxxxxxxxx><mailto:vgupta@xxxxxxxxxxxx> # for arc_uart
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/