Re: [PATCH] sched/core: Drop debugging leftover trace_printk call

From: Steven Rostedt
Date: Tue Apr 07 2015 - 10:10:44 EST

On Tue, 07 Apr 2015 07:01:37 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> o Please add a test for $realfile !~ m@kernel/trace/@
> or maybe $realfile !~ /(?:trace|tracing)/
> o ERROR seems a bit strong, WARN is probably good enough

I'm thinking ERROR is good. There's no reason to have it. In fact, you
must never have it. Looking at the other ERROR() conditions, I say this
is just as strong and perhaps even stronger. You have ERROR() for
trailing white space. This is much worse than that.

This isn't a 80 character limit problem. This is something that if you
add will be reverted right away, as it was for Juri's patch that added
a trace_printk() by mistake, and Boris followed it with a patch to
remove it.

-- Steve

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at