Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload

From: Christoph Hellwig
Date: Tue Apr 07 2015 - 11:19:24 EST


On Sun, Apr 05, 2015 at 11:50:06AM +0300, Boaz Harrosh wrote:
> [ +0.000537] pmem: init 2 devices => 0
>
> So I have all the information. And I know the driver was actually loaded
> successfully on the expected two regions.

The second number will always be 0, so no point in printing it.
Also device can be hotplugged at runtime, e.g. your magic PCIe device,
so iff you really want to print anything ->probe is the place for it.

But I still don't think we need it, once booted you can trivially look
up the information in sysfs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/