Re: [PATCH] sched/core: Remove wakeup_gran with single call calc_delta_fair

[Mike Galbraith]

On Tue, 2015-04-07 at 16:37 +0300, Abel Vesa wrote:
> On Tue, Apr 7, 2015 at 1:30 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx
> > wrote:
> > On Mon, Apr 06, 2015 at 09:43:43PM +0300, Abel Vesa wrote:
> > > This patch removes function wakeup_gran and its call by calling 
> > > directly
> > > calc_delta_fair function with sysctl_sched_wakeup_granularity 
> > > and se as arguments.
> > 
> > But why?
> 
> I was thinking that maybe reducing another function call would be a 
> better idea.
> I don't see what's the point of calling a 'wakeup_gran' just to
> declare 'gran' as local variable and then
> call calc_delta_fair instead of calling directly calc_delta_fair.
> Plus, I think it seems more
> readable to me. Of course, I might be wrong.

I expected it be inlined by gcc, but that didn't happen with gcc-4.8.3.

        -Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/