[PATCH 3.13.y-ckt 135/156] target: Fix reference leak in target_get_sess_cmd() error path

From: Kamal Mostafa
Date: Tue Apr 07 2015 - 19:01:34 EST

3.13.11-ckt19 -stable review patch. If anyone has any objections, please let me know.


From: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>

commit 7544e597343e2166daba3f32e4708533aa53c233 upstream.

This patch fixes a se_cmd->cmd_kref leak buf when se_sess->sess_tearing_down
is true within target_get_sess_cmd() submission path code.

This se_cmd reference leak can occur during active session shutdown when
ack_kref=1 is passed by target_submit_cmd_[map_sgls,tmr]() callers.

Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
Signed-off-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
drivers/target/target_core_transport.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 40f171b..d76c922 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -2289,6 +2289,10 @@ int target_get_sess_cmd(struct se_session *se_sess, struct se_cmd *se_cmd,
list_add_tail(&se_cmd->se_cmd_list, &se_sess->sess_cmd_list);
spin_unlock_irqrestore(&se_sess->sess_cmd_lock, flags);
+ if (ret && ack_kref)
+ target_put_sess_cmd(se_sess, se_cmd);
return ret;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/