Re: [PATCH V2] x86/numa: kernel stack corruption fix

[Xishi Qiu]

On 2015/4/8 9:46, Dave Young wrote:

>>>  
>>> -	/* Mark all kernel nodes. */
>>> +	/*
>>> +	 * Mark all kernel nodes.
>>> +	 *
>>> +	 * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo
>>
>> Hi Dave,
>>
>> It should both set mem=xx and numa=off, then numa_meminfo may not include all
>> the memblock.reserved memory, right?
> 
> Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such
> possiblity that it may happen even without numa=off. Just consider the non-snb board..
> 
> Thanks
> Dave
> 

Hi Dave,

I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
is right.

Reviewed-by: Xishi Qiu <qiuxishi@xxxxxxxxxx>

> .
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/