Re: [PATCH v5 3/6] arm64: Kprobes with single stepping support

[Pratyush Anand]

Hi Dave,

On Wed, Feb 18, 2015 at 4:41 AM, David Long <dave.long@xxxxxxxxxx> wrote:
>
> From: Sandeepa Prabhu <sandeepa.prabhu@xxxxxxxxxx>
>
> Add support for basic kernel probes(kprobes) and jump probes
> (jprobes) for ARM64.
>

[...]

>
> +#ifdef CONFIG_KPROBES
> +static inline int notify_page_fault(struct pt_regs *regs, unsigned int esr)
> +{
> +       int ret = 0;
> +
> +       /* kprobe_running() needs smp_processor_id() */
> +       if (!user_mode(regs)) {
> +               preempt_disable();
> +               if (kprobe_running() && kprobe_fault_handler(regs, esr))
> +                       ret = 1;
> +               preempt_enable();
> +       }
> +
> +       return ret;
> +}
> +#else
> +static inline int notify_page_fault(struct pt_regs *regs)

Please fix this definition in next revision, other wise there would be
a build error
if CONFIG_KPROBES is not defined.


should be:

+static inline int notify_page_fault(struct pt_regs *regs, unsigned int esr)


~Pratyush
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/