Re: [PATCH 1/2] perf, record: Add clockid parameter

[Peter Zijlstra]

On Tue, Apr 07, 2015 at 07:33:37PM +0200, Jiri Olsa wrote:
> On Tue, Apr 07, 2015 at 05:48:51PM +0200, Peter Zijlstra wrote:
> > On Tue, Apr 07, 2015 at 11:09:53AM +0200, Peter Zijlstra wrote:
> > > @@ -739,6 +813,7 @@ static struct record record = {
> > >  			.uses_mmap   = true,
> > >  			.default_per_cpu = true,
> > >  		},
> > > +		.clockid             = -1,
> > >  	},
> > 
> > As spotted by dahern this is not working well for all other record_opts
> > instances, fix that by adding a use_clockid field just like
> > perf_event_attr has.
> 
> hum, havent realized that.. I saw Arnaldo already included
> this one in pull req., anyway FWIW it looks ok ;-)

Yeah, I was slightly surprised to find out record_opts were used outside
of builtin-record.c, maybe a rename might be in order.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/