Re: [PATCH v3 1/2] mfd/axp20x: add support for extcon cell

From: Lee Jones
Date: Wed Apr 08 2015 - 05:49:44 EST


When submitting patches, please observe the $SUBJECT line formatting
of the subsystem you're sending to.

You can do so by: `git log --oneline -- drivers/<subsystem>`

In the case of MFD it's:

mfd: <device>: <Description>

Note the ':' separators and the capitalisation of the first letter of
the description string.

> This patch adds the mfd cell info for axp288 extcon device.
>
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@xxxxxxxxx>
> ---
> drivers/mfd/axp20x.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)

Nevertheless, patch applied, thanks.

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index b1b580a..4c8e0e9 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -290,6 +290,29 @@ static struct resource axp288_adc_resources[] = {
> },
> };
>
> +static struct resource axp288_extcon_resources[] = {
> + {
> + .start = AXP288_IRQ_VBUS_FALL,
> + .end = AXP288_IRQ_VBUS_FALL,
> + .flags = IORESOURCE_IRQ,
> + },
> + {
> + .start = AXP288_IRQ_VBUS_RISE,
> + .end = AXP288_IRQ_VBUS_RISE,
> + .flags = IORESOURCE_IRQ,
> + },
> + {
> + .start = AXP288_IRQ_MV_CHNG,
> + .end = AXP288_IRQ_MV_CHNG,
> + .flags = IORESOURCE_IRQ,
> + },
> + {
> + .start = AXP288_IRQ_BC_USB_CHNG,
> + .end = AXP288_IRQ_BC_USB_CHNG,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
> +
> static struct resource axp288_charger_resources[] = {
> {
> .start = AXP288_IRQ_OV,
> @@ -345,6 +368,11 @@ static struct mfd_cell axp288_cells[] = {
> .resources = axp288_adc_resources,
> },
> {
> + .name = "axp288_extcon",
> + .num_resources = ARRAY_SIZE(axp288_extcon_resources),
> + .resources = axp288_extcon_resources,
> + },
> + {
> .name = "axp288_charger",
> .num_resources = ARRAY_SIZE(axp288_charger_resources),
> .resources = axp288_charger_resources,

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/