Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

[Caesar Wang]

Heiko,

å 2015å04æ08æ 17:25, Heiko StÃbner åé:
> Hi Caesar,
>
> Am Mittwoch, 8. April 2015, 16:52:08 schrieb Caesar Wang:
> > To fix pop noise when shutdown,the pop noise during shutdown
> > is the pmic cutoff power of codec without any notice.
> >
> > Signed-off-by: jay.xu <xjq@xxxxxxxxxxxxxx>
> > Signed-off-by: zhengxing <zhengxing@xxxxxxxxxxxxxx>
> > Signed-off-by: Caesar Wang <wxt@xxxxxxxxxxxxxx>
> >
> > Serien-cc: linux-kernel@xxxxxxxxxxxxxxx
> > Serien-cc: devicetree@xxxxxxxxxxxxxxx
> > Serien-cc: dianders@xxxxxxxxxxxx
> >
> > ---
> >
> >   sound/soc/codecs/max98090.c | 17 +++++++++++++++++
> >   1 file changed, 17 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
> > index b112b1c..066954a0 100644
> > --- a/sound/soc/codecs/max98090.c
> > +++ b/sound/soc/codecs/max98090.c
> > @@ -2611,6 +2611,22 @@ static int max98090_i2c_remove(struct i2c_client
> > *client) return 0;
> >   }
> >
> > +static void max98090_i2c_shutdown(struct i2c_client *i2c)
> > +{
> > +	struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev);
> > +
> > +	dev_info(&i2c->dev, "shut down device\n");
> is this dev_info really necessary? dev_dbg might be better, or leave it out
> completely, as it doesn't really provide any additional benefit.

As Mark suggestion, I will remove it.
> > +
> > +	/* Enable volume smoothing, disable zero cross.  This will cause
> > +	 * a quick 40ms ramp to mute on shutdown.
> > +	 */
> Comment style is off ... should be
>
> /*
>   * Enable volume smoothing, disable zero cross.  This will cause
>   * a quick 40ms ramp to mute on shutdown.
>   */

Done
> > +	regmap_write(max98090->regmap,
> > +		M98090_REG_LEVEL_CONTROL, M98090_VSENN_MASK);
> > +	regmap_write(max98090->regmap,
> > +		M98090_REG_DEVICE_SHUTDOWN, 0x00);
> > +	msleep(40);
> > +}
> > +
> >   #ifdef CONFIG_PM
> >   static int max98090_runtime_resume(struct device *dev)
> >   {
> > @@ -2697,6 +2713,7 @@ static struct i2c_driver max98090_i2c_driver = {
> >   	},
> >   	.probe  = max98090_i2c_probe,
> >   	.remove = max98090_i2c_remove,
> > +	.shutdown = max98090_i2c_shutdown,
> >   	.id_table = max98090_i2c_id,
> >   };

--
**************************************************************************************
çæè    Caesar Wang
ççäåäé   Product R&D Dept.III
çåçèåçåæéåå Fuzhou Rockchip Electronics Co.Ltd
ååïçåççååéçèèäåé89åèäåAå18åæ ïçåæéï
        æååååçæääèäåèåå21å ïæååååï
Addrï  NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters)
         21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen  (Shenzhen Office)
Telï+86-591-83991906/07 - 8221
Mobile:+86 15059456742
E-mail : wxt@xxxxxxxxxxxxxx
***************************************************************************************
***************************************************************************************
äåæçïæéäååéäåææåäæïäåéçæéäææçåæääãèéèçåæääïèåååã äçææéæéäçääååã
èèææéäïèäççäæäæåéæéäåææéäïåäååéäæåäæååååçåääãçåçèåçåæéååæææéää
æçèäæåèéæïçæääæçææèåçäæèäã
 
IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may
contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA.
If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the
information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material
in its entirety in any format. Thank you.
***************************************************************************************


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/