Re: [PATCH] ASoC: max98090: add shutdown callback for max98090

[Caesar Wang]

Mark,


å 2015å04æ08æ 17:50, Mark Brown åé:
> On Wed, Apr 08, 2015 at 04:52:08PM +0800, Caesar Wang wrote:
>
> > +static void max98090_i2c_shutdown(struct i2c_client *i2c)
> > +{
> > +	struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev);
> > +
> > +	dev_info(&i2c->dev, "shut down device\n");
> Remove this, it's adding noise.

Done
> > +
> > +	/* Enable volume smoothing, disable zero cross.  This will cause
> > +	 * a quick 40ms ramp to mute on shutdown.
> > +	 */
> > +	regmap_write(max98090->regmap,
> > +		M98090_REG_LEVEL_CONTROL, M98090_VSENN_MASK);
> > +	regmap_write(max98090->regmap,
> > +		M98090_REG_DEVICE_SHUTDOWN, 0x00);
> > +	msleep(40);
> > +}
> This is OK but equivalent code should be being added to the driver
> remove path as the same thing should be happening there.
Yeah.I will fix it in v2 patch.

Thanks!

--
**************************************************************************************
çæè    Caesar Wang
ççäåäé   Product R&D Dept.III
çåçèåçåæéåå Fuzhou Rockchip Electronics Co.Ltd
ååïçåççååéçèèäåé89åèäåAå18åæ ïçåæéï
        æååååçæääèäåèåå21å ïæååååï
Addrï  NO.18 Building, A District, Fuzhou Software Park,Gulou District,Fuzhou, Fujian,China(Fuzhou Headquarters)
         21F,Malata Building,Kejizhongyi Avenue,Nanshan District,Shenzhen  (Shenzhen Office)
Telï+86-591-83991906/07 - 8221
Mobile:+86 15059456742
E-mail : wxt@xxxxxxxxxxxxxx
***************************************************************************************
***************************************************************************************
äåæçïæéäååéäåææåäæïäåéçæéäææçåæääãèéèçåæääïèåååã äçææéæéäçääååã
èèææéäïèäççäæäæåéæéäåææéäïåäååéäæåäæååååçåääãçåçèåçåæéååæææéää
æçèäæåèéæïçæääæçææèåçäæèäã
 
IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may
contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA.
If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the
information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material
in its entirety in any format. Thank you.
***************************************************************************************


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/