Re: [RESEND PATCH 4.0-rc5 v19 3/6] irqchip: gic: Introduce plumbing for IPI FIQ

[Daniel Thompson]

On 08/04/15 09:19, Hillf Danton wrote:
> > +/*
> > + * Fully acknowledge (both ack and eoi) any outstanding FIQ-based IPI,
> > + * otherwise do nothing.
> > + */
> > +void gic_handle_fiq_ipi(void)
> > +{
> > +	struct gic_chip_data *gic = &gic_data[0];
> > +	void __iomem *cpu_base = gic_data_cpu_base(gic);
> > +	unsigned long irqstat, irqnr;
> > +
> > +	if (WARN_ON(!in_nmi()))
> > +		return;
> > +
> > +	while ((1u << readl_relaxed(cpu_base + GIC_CPU_HIGHPRI)) &
> > +	       SMP_IPI_FIQ_MASK) {
> > +		irqstat = readl_relaxed(cpu_base + GIC_CPU_INTACK);
> > +		writel_relaxed(irqstat, cpu_base + GIC_CPU_EOI);
> > +
> > +		irqnr = irqstat & GICC_IAR_INT_ID_MASK;
> > +		WARN_RATELIMIT(irqnr > 16,
> > +			       "Unexpected irqnr %lu (bad prioritization?)\n",
>
> Help more if s/Unexpected/Unexpected FIQ/ ?

The GIC logic to prioritize interrupts is independent of the logic to 
route interrupt sources to IRQ or FIQ. Thus if this code acknowledges an 
unexpected interrupt source then we really don't know whether it is an 
IRQ or a FIQ so we cannot accurately describe this is an unexpected FIQ.

If there is bad prioritization then we cannot predict what type of 
interrupt INTACK will give use.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/