Re: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus

From: Peter Zijlstra
Date: Wed Apr 08 2015 - 13:28:04 EST


On Wed, Apr 08, 2015 at 11:21:56AM -0400, Chris Metcalf wrote:
> Apparently the body of the commit message isn't as clear as it might be :-)
>
> It does say the same thing, though, basically that if nohz_full DOESN'T
> imply isolcpus, that's a bad thing. I'm happy to reword the text to avoid
> the double negative and say:
>
> nohz_full is only useful with isolcpus also set, since otherwise the
> scheduler has to run periodically to try to determine whether to steal
> work from other cores.

But you're doing the reverse! You're setting nohz_full for isolcpus, not
limiting the nohz_full mask to isolcpus.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/