Re: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus

[Peter Zijlstra]

On Wed, Apr 08, 2015 at 02:12:34PM -0400, Chris Metcalf wrote:

> >But you're doing the reverse! You're setting nohz_full for isolcpus, not
> >limiting the nohz_full mask to isolcpus.
> 
> Ah, I see.  Yes, that's right.  

No its not, you should correct me when I'm wrong ;-)

So the problem is that:

+       tick_nohz_full_set_cpus(cpu_isolated_map);

reads like you're doing:

  nohz_full_map |= isolcpus_map

But in actual fact you're doing:

  isolcpus_map |= nohz_full_map

So that function is retarded, but the logic is fine.

So NAK on both patches for the reason that they're utterly confusing as
to wtf they actually do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/