Re: [PATCH 4/8] clk: tegra: Fix duplicate const for parent names

From: Thierry Reding
Date: Thu Apr 09 2015 - 06:20:05 EST


On Thu, Apr 09, 2015 at 12:07:59PM +0200, Krzysztof Kozlowski wrote:
> 2015-04-09 12:00 GMT+02:00 Thierry Reding <thierry.reding@xxxxxxxxx>:
> > On Wed, Apr 08, 2015 at 03:22:15PM +0200, Krzysztof Kozlowski wrote:
> >> Replace duplicated const keyword for 'emc_parent_clk_names' with proper
> >> array of const pointers to const strings.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> >> ---
> >> drivers/clk/tegra/clk-emc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This would probably better go in via the Tegra tree since the patch that
> > contains this has only made it to linux-next.
> >
> > Stephen, Mike, any objections to me taking this?
>
> Applying this without the change for const-ness of parent_names (patch
> by Sascha Hauer sent before mine [1]) would introduce a warning -
> assign of const to non-const. Any idea to solve it? Immutable branch?

Right, I had missed that. Immutable branch would work, though perhaps
it'd be easier to just defer this until after v4.1-rc1. The warning
shouldn't happen if we leave out this single patch and apply it later
on, right?

Alternatively the whole series could be deferred until after v4.1-rc1.

Thierry

Attachment: pgpwxzAJS53Oj.pgp
Description: PGP signature