Re: [PATCH 8/8] iio: accel: mma9553: add enable channel for activity
From: Jonathan Cameron
Date: Thu Apr 09 2015 - 07:52:57 EST
On 08/04/15 15:37, Irina Tirdea wrote:
> Since we need to specifically power on the device if used
> in polling mode, we have an enable channel for each type
> (step count, distance, speed, calories, etc.).
>
> Add also an enable channel for activity, so it can also
> be polled independenly of events or other channels.
>
typo - independently
> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
> Suggested-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>
For the ones that are bug fixes wants to be reported-by
to get correctly picked up in the gitdm stats etc.
Again, this looks to be a fix to me so up the top of the series
please.
J
> ---
> drivers/iio/accel/mma9553.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index 6991b01..1359985 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -942,7 +942,8 @@ static const struct iio_chan_spec_ext_info mma9553_ext_info[] = {
> .modified = 1, \
> .channel2 = _chan2, \
> .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \
> - .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_CALIBHEIGHT), \
> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_CALIBHEIGHT) | \
> + BIT(IIO_CHAN_INFO_ENABLE), \
> .event_spec = mma9553_activity_events, \
> .num_event_specs = ARRAY_SIZE(mma9553_activity_events), \
> .ext_info = mma9553_ext_info, \
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/