Re: [RFC PATCH 2/2] iio: light: Add support for LTR559 chip

[Daniel Baluta]

On 04/09/2015 04:39 PM, Jonathan Cameron wrote:
> On 31/03/15 11:37, Daniel Baluta wrote:
> > This device is register compatible with LTR501, with a minor difference for
> > ALS control register as showed below:
> >
> > ALS Control register for LTR501:
> >
> >      7      6      5      4      3      2      1      0
> > +------+------+------+------+------+------+------+------+
> > |                           |      |      |             |
> > |        Reserved           | Gain |  SW  |    ALS Mode |
> > |                           |      | Reset|             |
> > +------+------+------+------+------+------+------+------+
> >
> > ALS Control register for LTR559:
> >
> >      7      6      5      4      3      2      1      0
> > +------+------+------+------+------+------+------+------+
> > |                    |                    |      |      |
> > |     Reserved       |        Gain        |  SW  | ALS  |
> > |                    |                    | Reset| Mode |
> > +------+------+------+------+------+------+------+------+
> >
> > We handle this difference by introducing ltr501_chip_info.
> >
> > Datasheet for LTR559 is at:
> > http://optoelectronics.liteon.com/upload/download/DS86-2013-0003/S_110_LTR-559ALS-01_DS_V1.pdf
> >
> > Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxxxx>
> Looks good to me.  Let us know when you've tested it ;)
> Anyhow, one comment inline.  It 'think' you can end up with a device probing
> succesfully with no known name...

Good point.

thanks,
Daniel.

<snip>

> > -	indio_dev->name = LTR501_DRV_NAME;
> > +	indio_dev->name = name;
> Can name still be NULL?  Needs a default value that makes sense.
> >   	indio_dev->modes = INDIO_DIRECT_MODE;

I will fix this and sync with Sathya for the LTR301 support.

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/