Re: [PATCH v4 6/9] rbtree: Implement generic latch_tree

[Linus Torvalds]

On Thu, Apr 9, 2015 at 5:13 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
>  struct latch_tree_node {
> +       struct rb_node node[2];
>  };
>
> +static __always_inline struct latch_tree_node *
> +__lt_from_rb(struct rb_node *node, int idx)
> +{
> +       return container_of(node, struct latch_tree_node, node[idx]);
> +}

Ugh. That syntax of offset_of() worries me a bit, but some grepping
shows that we already use this form of offset_of() in parts of the
kernel, so I guess it's fine.

Even with that small "Ugh", I do have to admit to preferring this to
having the back-pointer.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/