[PATCH v3 2/3] tty: serial: msm: Remove duplicate operations on clocks in startup/shutdown

From: Pramod Gurav
Date: Fri Apr 10 2015 - 08:21:47 EST


clk_prepare_enable/clk_disable_unprepare is already done in .pm
function of uart_ops hence get rid of them from msm_startup and
msm_shutdown.

Signed-off-by: Pramod Gurav <gpramod@xxxxxxxxxxxxxx>
---
Changes since last version:
- Decided to drop calls to clk operations

drivers/tty/serial/msm_serial.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 99aba04..c32b088 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -494,8 +494,6 @@ static int msm_startup(struct uart_port *port)
if (unlikely(ret))
return ret;

- msm_init_clock(port);
-
if (likely(port->fifosize > 12))
rfr_level = port->fifosize - 12;
else
@@ -525,8 +523,6 @@ static void msm_shutdown(struct uart_port *port)
msm_port->imr = 0;
msm_write(port, 0, UART_IMR); /* disable interrupts */

- clk_disable_unprepare(msm_port->clk);
-
free_irq(port->irq, port);
}

@@ -683,8 +679,7 @@ static void msm_power(struct uart_port *port, unsigned int state,

switch (state) {
case 0:
- clk_prepare_enable(msm_port->clk);
- clk_prepare_enable(msm_port->pclk);
+ msm_init_clock(port);
break;
case 3:
clk_disable_unprepare(msm_port->clk);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/