Re: [PATCH] drivers/usb/core: hcd.c: Removed all space warnings from checkpatch.pl

From: Joe Perches
Date: Sat Apr 11 2015 - 12:20:18 EST


On Sat, 2015-04-11 at 03:04 -0700, Chase Metzger wrote:
> Removed all(except false positives, from calculations) space prohibited warnings generated by
> checkpatch.pl.

False positives? Please describe them.

The only thing I believe you elided was the
use of a BitTime macro which in my opinion
should be used as a function.

drivers/usb/core/hcd.c: tmp = (67667L * (31L + 10L * BitTime (bytecount))) / 1000L;

as it is in the include file:

include/linux/usb/hcd.h: + (2083UL * (3 + BitTime(bytes))))/1000 \


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/