Re: [PATCH v5 05/10] seqlock: Better document raw_write_seqcount_latch()

From: Linus Torvalds
Date: Mon Apr 13 2015 - 14:21:54 EST


On Mon, Apr 13, 2015 at 10:43 AM, Paul E. McKenney
<paulmck@xxxxxxxxxxxxxxxxxx> wrote:
>
> A shorthand for READ_ONCE + smp_read_barrier_depends() is the shiny
> new lockless_dereference()

Related side note - I think people should get used to seeing
"smp_load_acquire()". It has well-defined memory ordering properties
and should generally perform well on most architectures. It's (much)
stronger than lockless_dereference(), and together with
smp_store_release() you can make rather clear guarantees about passing
data locklessly from one CPU to another.

I'd like to see us use more of the pattern of

- one thread does:

.. allocate/create some data
smp_store_release() to "expose it"

- another thread does:

smp_load_acquire() to read index/pointer/flag/whatever
.. use the data any damn way you want ..

and we should probably aim to prefer that pattern over a lot of our
traditional memory barriers.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/