Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe
From: Johan Hovold
Date: Tue Apr 14 2015 - 09:04:16 EST
Hi Mark and Lee,
On Thu, Mar 26, 2015 at 08:32:09AM +0000, Lee Jones wrote:
> On Wed, 25 Mar 2015, Johan Hovold wrote:
>
> > Fix broken probe of da9052 regulators, which since commit b3f6c73db732
> > ("mfd: da9052-core: Fix platform-device id collision") use a
> > non-deterministic platform-device id to retrieve static regulator
> > information. Fortunately, adequate error handling was in place so probe
> > would simply fail with an error message.
> >
> > Update the mfd-cell ids to be zero-based and use those to identify the
> > cells when probing the regulator devices.
> >
> > Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision")
> > Cc: stable <stable@xxxxxxxxxxxxxxx> # v3.19
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > ---
> > drivers/mfd/da9052-core.c | 8 ++++----
> > drivers/regulator/da9052-regulator.c | 5 +++--
>
> Need an Ack from Mark, but looks good to me.
>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
Mark, did you have a chance to look at this one?
It fixes a regression due to an mfd commit, but not sure who of you that
wants to take it.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/