Re: [PATCH 2/2] More precise timestamps for nested writes

[Peter Zijlstra]

On Mon, Apr 13, 2015 at 09:38:01PM -0500, Suresh E. Warrier wrote:
> +static u64 *get_write_timestamp(struct ring_buffer_per_cpu *cpu_buffer,
> +				unsigned long *flags)
> +{
> +	if (rb_precise_nested_write_ts()) {
> +		/*
> +		 * Ensure that we are not preempted until after we update
> +		 * the write timestamp.
> +		 */
> +		local_irq_save(*flags);
> +		return &cpu_buffer->last_stamp;

Yeah, ever hear about NMIs? This isn't going to work.

> +	} else {
> +		return &cpu_buffer->write_stamp;
> +	}
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/