Re: [PATCH 1/3] sched, timer: Remove usages of ACCESS_ONCE in the scheduler

[Steven Rostedt]

On Tue, 14 Apr 2015 16:09:44 -0700
Jason Low <jason.low2@xxxxxx> wrote:


> @@ -2088,7 +2088,7 @@ void task_numa_fault(int last_cpupid, int mem_node, int pages, int flags)
>  
>  static void reset_ptenuma_scan(struct task_struct *p)
>  {
> -	ACCESS_ONCE(p->mm->numa_scan_seq)++;
> +	WRITE_ONCE(p->mm->numa_scan_seq, READ_ONCE(p->mm->numa_scan_seq) + 1);

Is the READ_ONCE() inside the WRITE_ONCE() really necessary?

>  	p->mm->numa_scan_offset = 0;
>  }
>  

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/