Re: [PATCH kernel v8 01/31] vfio: powerpc/spapr: Move page pinning from arch code to VFIO IOMMU driver

[David Gibson]

On Fri, Apr 10, 2015 at 04:30:43PM +1000, Alexey Kardashevskiy wrote:
> This moves page pinning (get_user_pages_fast()/put_page()) code out of
> the platform IOMMU code and puts it to VFIO IOMMU driver where it belongs
> to as the platform code does not deal with page pinning.
> 
> This makes iommu_take_ownership()/iommu_release_ownership() deal with
> the IOMMU table bitmap only.
> 
> This removes page unpinning from iommu_take_ownership() as the actual
> TCE table might contain garbage and doing put_page() on it is undefined
> behaviour.
> 
> Besides the last part, the rest of the patch is mechanical.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@xxxxxxxxx>

Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: pgpIiq6lhEOXI.pgp
Description: PGP signature