Re: [PATCH kernel v8 08/31] vfio: powerpc/spapr: Rework groups attaching

From: David Gibson
Date: Wed Apr 15 2015 - 04:33:05 EST

On Fri, Apr 10, 2015 at 04:30:50PM +1000, Alexey Kardashevskiy wrote:
> This is to make extended ownership and multiple groups support patches
> simpler for review.
> This is a mechanical patch.

I think you're pushing the meaning of that term. Moving whole slabs
of code by copy/paste I'd call mechanical. Reworking logic in this
way, not so much. Say "This should cause no behavioural change" if
that's what you mean.

> Signed-off-by: Alexey Kardashevskiy <aik@xxxxxxxxx>

Though it's not instantly obvious, it does look as though it makes no
behavioural change though, so:

Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>

David Gibson | I'll have my music baroque, and my code
david AT | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!

Attachment: pgp0ueKQyNvn4.pgp
Description: PGP signature