Re: [PATCH V2 linux-next] scripts/coccinelle/misc/bugon.cocci: update bug_on conversion warning

From: Michal Marek
Date: Wed Apr 15 2015 - 08:22:39 EST


On 2015-04-09 22:58, Fabian Frederick wrote:
> if()/BUG conversion to BUG_ON must be avoided when there's side effect
> in condition. The reason being BUG_ON won't execute the condition when CONFIG_BUG
> is not defined.
>
> Inspired-by: J. Bruce Fields <bfields@xxxxxxxxxxxx>
> Suggested-by: Julia Lawall <Julia.Lawall@xxxxxxx>
> Acked-by: Julia Lawall <Julia.Lawall@xxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
> V2: s/condition/the condition/

Applied to kbuild.git#misc.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/